Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Navbar: data-iconpos is ignored #1797#1858

Closed
pravinkmrr wants to merge 2 commits intojquery-archive:masterfrom
pravinkmrr:master
Closed

Navbar: data-iconpos is ignored #1797#1858
pravinkmrr wants to merge 2 commits intojquery-archive:masterfrom
pravinkmrr:master

Conversation

@pravinkmrr
Copy link

NOTE: this may simply be a documentation bug - data-iconpos works on the navbar element itself.

Navbar: data-iconpos is ignored bug fixed in navbar plugin

@scottjehl
Copy link

I think this is more of a documentation problem. On navbars, iconPos is set data-attributes on the navbar element, because the position is shared across the set. I just verified that that is working fine still. Does that work for you? I can update the docs...

@pravinkmrr
Copy link
Author

may be. but i changed the script to use top,bottom,right,left as well as notext for data-iconpos...

@scottjehl
Copy link

Okay. Do any of those properties not work currently on the navbar element? Just want to make sure we fix this bug in the right place. Thanks!

@pravinkmrr
Copy link
Author

Okay. Hope i will support.

@toddparker
Copy link
Contributor

I'm not sure I understand where this was left off. Does this work already? Do the docs need to be updated?

@ahutch
Copy link

ahutch commented Oct 1, 2011

The doc still says : "Icons can be stacked above the labels by adding the data-iconpos="top" attribute to each anchor."

However data-iconpos=".." only works when placed in the container that has data-role="navbar"

I wish that the behavior was that of the document. That way I could pick the position per anchor. Left for the button on the left and right for the button on the right.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants